Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve code for orders in algebras #1337

Merged
merged 1 commit into from
Jan 7, 2024
Merged

feat: improve code for orders in algebras #1337

merged 1 commit into from
Jan 7, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Dec 27, 2023

  • Restructure the files for PIP
  • Make basis matrix not have zero rows

@thofma thofma force-pushed the th/pip branch 3 times, most recently from 22d8527 to 5bcabb1 Compare December 27, 2023 21:57
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Merging #1337 (7edb60f) into master (6f0a045) will decrease coverage by 0.37%.
The diff coverage is 44.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
- Coverage   74.64%   74.27%   -0.37%     
==========================================
  Files         346      351       +5     
  Lines      112079   111805     -274     
==========================================
- Hits        83656    83046     -610     
- Misses      28423    28759     +336     
Files Coverage Δ
src/AlgAss/AbsAlgAss.jl 91.54% <100.00%> (+0.08%) ⬆️
src/AlgAss/AlgMatElem.jl 85.10% <100.00%> (ø)
src/AlgAss/Elem.jl 86.91% <ø> (-0.03%) ⬇️
src/AlgAssAbsOrd/Conjugacy/Conjugacy.jl 98.32% <100.00%> (ø)
src/AlgAssAbsOrd/Conjugacy/Husert.jl 91.30% <100.00%> (ø)
src/AlgAssAbsOrd/ICM.jl 87.69% <100.00%> (ø)
src/AlgAssAbsOrd/PIP.jl 10.34% <ø> (-40.45%) ⬇️
src/AlgAssAbsOrd/Quotient.jl 100.00% <100.00%> (ø)
src/LinearAlgebra/FakeFmpqMat.jl 64.90% <100.00%> (ø)
src/Misc/Matrix.jl 76.26% <100.00%> (+0.50%) ⬆️
... and 14 more

... and 43 files with indirect coverage changes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
- Restructure the files for PIP
- Make basis matrix not have zero rows
@thofma thofma merged commit e789599 into master Jan 7, 2024
@thofma thofma deleted the th/pip branch January 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant